Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Unknown subcommands don't error #2955

Closed
achingbrain opened this issue Mar 26, 2020 · 2 comments · May be fixed by baby636/js-ipfs#181, thexdesk/js-ipfs#11, zi3lak/js-ipfs#10, internetbuilder/js-ipfs#41 or thexdesk/js-ipfs#33
Assignees
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws) kind/wontfix-migration-available pkg:ipfs

Comments

@achingbrain
Copy link
Member

They should exit with a non-zero status

$ jsipfs derp
..
$ echo $?
1
$ jsipfs repo derp
..
$ echo $?
0
@achingbrain achingbrain added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up pkg:ipfs labels Mar 26, 2020
@hmalik88
Copy link

hmalik88 commented Jul 25, 2020

@achingbrain Hi! I'd like to tackle this issue. This would be my first open source contribution, I looked into exit statuses and understand that an unknown command shouldn't be spitting back 0. I guess there would be a bash file that's handling the various ipfs commands? I imagine this would be an easy fix but I'm not sure where to start looking.

p.s. sorry if i'm tagging you much, I'm really excited to contribute and be useful.

@whizzzkid
Copy link

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments before 2023-06-05. We will do a final pass on reopened issues afterward (see #4336).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.