Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken BOOST_OS_LINUX guard block #190

Closed
wants to merge 1 commit into from

Conversation

michi42
Copy link

@michi42 michi42 commented Feb 3, 2021

The "BOOST_OS_LINUX" preprocessor guard block in Paths.cpp is broken, which leads to build errors on Windows (#184).

According to the boost-predef docs https://www.boost.org/doc/libs/1_66_0/doc/html/predef.html

Version numbers that are always defined so that one doesn't have to guard with #ifdef.

Therefore, the #ifdef check passes even if the OS is not Linux.
These macros should be checked using #if directives.

@thezbyg
Copy link
Owner

thezbyg commented May 8, 2022

OS macro usage fixed in 3ba7b57.
Thanks.

@thezbyg thezbyg closed this May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants