Add checks for Steam Linux install locations #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added checks for a few common locations where Steam might install the game on Linux, checking a Linux-specific environment variable to get the user directory.
Just a tiny little inconsequential change because I didn't like how I used the linuxUserPath variable before. (Re-tested anyway to avoid stupid mistakes.) Feel free to combine with the original commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added checks for a few common locations where Steam might install the game on Linux, checking a Linux-specific environment variable to get the user directory. When tested, it was able to find the game when it was installed at the first listed location.
I noticed this code comment when I was hunting through the files figuring them out, and it seemed like the perfect thing for me to add, since I run the game and randomizer entirely on Ubuntu with Proton. (Also, it's purely for QoL during first setup, and won't break if the user's file tree is in some bizarre configuration.) As a possible next step, this section of Settings.java could also be modified to check common save data locations, including locations used by Proton as well as Windows and Linux builds running natively, and determine which location is in use by whether it contains a lamu.dat file.
I had plans for bigger contributions, especially to do with seed export/import, but I've been told to "start small," and also I'm not very good at using git yet. So I'm not going to overhaul anything right now, and if I do, it may end up confined to my own fork.