Bright black should be darkgray

[vpelletier]

1;30 is rendered as black text, while it should be darkgray (#555 according to wikipedia standard VGA color table).

[theZiz]

Thanks for the report! Hopefully fixed it:
697922a

[vpelletier]

Thank you very much for the quick fix !
I confirm it works as expected now (I only tested text color, not background).

[theZiz]

In fact I thought, that the background color 0 in contrast to the foreground color 0 should be black instead of darkgray.
So I fixed this only for the foreground color.

Do I need to fix the background color, too?
I took a look at this page only now:
http://en.wikipedia.org/wiki/ANSI_escape_code
Before I did just have a look, how my terminal emulator handles the color.

This source says, \033[1 is increased intensity (which would make darkgray out of black) or bold.
So if I use bold already, should the foreground colour then be black anyway?

Or if I use both (bold and brighter color), shouldn't I "bright up" the other colours, too?

Would it be furthermore not more correct to use darkgray only for bright/bold letters? I use it now for both, because my terminal emulator does the same.

Maybe I should just not try to be too correct... Otherwise I could just rewrite the whole application. :\

On Sat, 24 Jan 2015 06:17:23 -0800
Vincent Pelletier notifications@github.com wrote:

Thank you very much for the quick fix !
I confirm it works as expected now (I only tested text color, not background).

---

Reply to this email directly or view it on GitHub:
#9 (comment)

[vpelletier]

True, it can be interpreted as bold too.
I guess there is just no correct implementation, but at best consistent implementations.
I probably should just use another colour in my program, for the same reason.

FYI, here are a few files generated via aha:
https://github.com/vpelletier/ITI1480A-linux/tree/master/examples
and especially hci_endianness_bug.usb_vvv.html , which uses darkgray in several places: hexdump offsets and less interesting capture events.

[theZiz]

Looks quite good. Maybe the most important thing is, that the colours are readable, quite close to the terminal output and of course readable.

So I will just keep it this new way, I thing it is a good compromise.

Thanks for your examples. Always nice to see, how other people use my work. :D

On Sat, 24 Jan 2015 10:10:20 -0800
Vincent Pelletier notifications@github.com wrote:

True, it can be interpreted as bold too.
I guess there is just no correct implementation, but at best consistent implementations.
I probably should just use another colour in my program, for the same reason.

FYI, here are a few files generated via aha:
https://github.com/vpelletier/ITI1480A-linux/tree/master/examples
and especially hci_endianness_bug.usb_vvv.html , which uses darkgray in several places: hexdump offsets and less interesting capture events.

---

Reply to this email directly or view it on GitHub:
#9 (comment)