-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bright black should be darkgray #9
Comments
Thanks for the report! Hopefully fixed it: |
Thank you very much for the quick fix ! |
In fact I thought, that the background color 0 in contrast to the foreground color 0 should be black instead of darkgray. Do I need to fix the background color, too? This source says, \033[1 is increased intensity (which would make darkgray out of black) or bold. Or if I use both (bold and brighter color), shouldn't I "bright up" the other colours, too? Would it be furthermore not more correct to use darkgray only for bright/bold letters? I use it now for both, because my terminal emulator does the same. Maybe I should just not try to be too correct... Otherwise I could just rewrite the whole application. :\ On Sat, 24 Jan 2015 06:17:23 -0800
|
True, it can be interpreted as bold too. FYI, here are a few files generated via aha: |
Looks quite good. Maybe the most important thing is, that the colours are readable, quite close to the terminal output and of course readable. So I will just keep it this new way, I thing it is a good compromise. Thanks for your examples. Always nice to see, how other people use my work. :D On Sat, 24 Jan 2015 10:10:20 -0800
|
1;30 is rendered as black text, while it should be darkgray (#555 according to wikipedia standard VGA color table).
The text was updated successfully, but these errors were encountered: