Cross-origin isolation support in Chrome #67
Conversation
…n=anonymous to injected script tag
| @@ -8,7 +8,32 @@ export default { | |||
| format: 'cjs', | |||
| }, | |||
| plugins: [ | |||
| serve({ contentBase: '', port: Math.round(Math.random() * 10000) + 40000 }), | |||
| live(), | |||
| serve({ | |||
There was a problem hiding this comment.
Do you have an idea of how to test this in CI?
There was a problem hiding this comment.
hi @thgh, do you mean testing plugin serve with that specific configuration?
I suppose we could set GH actions with node.js to capture the output of rollup.
Would you require this to approve this PR? I see that there is no CI setup in place yet.
There was a problem hiding this comment.
Had a peek at how node-livereload does the server testing.
https://github.com/frantic0/node-livereload/blob/main/test/index.test.coffee
It is a travis CI setup and does include server configurations
There was a problem hiding this comment.
No requirement, just looking for inspiration
I'm not using this plugin actively so we should start doing automated testing to remain confident when releasing. I hope to make it a requirement soon.
removed and installed livereload to latest
| @@ -8,7 +8,32 @@ export default { | |||
| format: 'cjs', | |||
| }, | |||
| plugins: [ | |||
| serve({ contentBase: '', port: Math.round(Math.random() * 10000) + 40000 }), | |||
| live(), | |||
| serve({ | |||
There was a problem hiding this comment.
hi @thgh, do you mean testing plugin serve with that specific configuration?
I suppose we could set GH actions with node.js to capture the output of rollup.
Would you require this to approve this PR? I see that there is no CI setup in place yet.
|
@frantic0 thanks for the PR. Could you rebase it and fix the merge conflicts? |
|
This PR depends on an open PR in livereload: napcs/node-livereload#155 To land this, we will need patch-package or a published fork of livereload |
|
👋 I have this PR for LiveReload that addresses CORS and CORP - it's a different one than you referenced here.napcs/node-livereload#164 Would this be adequate for what you need? |
Closes #66