Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hiccup / hiccup-svg] add support for context object #19

Closed
postspectacular opened this issue May 9, 2018 · 0 comments
Closed

[hiccup / hiccup-svg] add support for context object #19

postspectacular opened this issue May 9, 2018 · 0 comments
Labels
bug Something isn't working package:hiccup package:hiccup-svg

Comments

@postspectacular
Copy link
Member

postspectacular commented May 9, 2018 •
edited
Loading

In order to keep hiccup & hiccup-svg compatible with components created for hdom, we need to update its handling of component fns and update serialize() to accept an additional / optional context arg, which is then passed to all embedded component fns as first arg (as done in hdom). Currently this is broken for components relying on the recent changes done in hdom.

Updating SVG components in hiccup-svg with the extra context arg will most likely result in breaking changes, but seemingly unavoidable and better done rather sooner than later...
@postspectacular postspectacular changed the title [hiccup] add support for context object [hiccup / hiccup-svg] add support for context object May 9, 2018
postspectacular added a commit that referenced this issue May 13, 2018
@postspectacular
docs(hiccup-svg): resolve #19, update readme, add invocation notes
dc77540 
BREAKING CHANGE: technically identical to previous version, however
due to breaking changes and new context support in @thi.ng/hiccup,
SVG functions MUST be invoked directly now and do not support lazy
evaluation anymore. see notice in readme.
postspectacular added a commit that referenced this issue May 13, 2018
@postspectacular
Merge branch 'feature/hiccup-context' into develop
01f0fa5 
* feature/hiccup-context:
  docs(hiccup): update readme
  refactor(examples): update svg examples
  docs(hiccup-svg): resolve #19, update readme, add invocation notes
  feat(pointfree): add execjs for host calls, update readme
  refactor(hiccup-svg): rename svgdoc => svg
  docs(hiccup): update readme
  perf(hiccup): update css()
  refactor(hiccup): fix #19, add support for context object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working package:hiccup package:hiccup-svg
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@postspectacular