Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that @config exists. Fixes #413 #528

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Commits on Jun 21, 2019

  1. Configuration menu
    Copy the full SHA
    74145f1 View commit details
    Browse the repository at this point in the history

Commits on Jun 25, 2019

  1. Start on setting up sample_app -- not working

    Running cucumber gives the error:
    
    cannot load such file -- test/unit (LoadError)
    calh committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    48090f0 View commit details
    Browse the repository at this point in the history
  2. Ooops, revert a couple files.

    These weren't supposed to make it into this PR
    calh committed Jun 25, 2019
    Configuration menu
    Copy the full SHA
    8e2671d View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2019

  1. Check that @config exists. Fixes thiagopradi#413

    Error message is:
    
    ActiveRecord::StatementInvalid: NoMethodError: undefined method `[]' for
    nil:NilClass:
    
      from octopus/lib/octopus/abstract_adapter.rb:23:in `octopus_shard'
      from octopus/lib/octopus/abstract_adapter.rb:12:in `instrument'
      from vendor/bundle/ruby/2.3.0/gems/activerecord-4.2.11.1/lib/active_record/connection_adapters/abstract_adapter.rb:478:in `log'
    
    This has shown to surface in the ibm_db and sqlserver adapters.
    calh committed Jun 26, 2019
    Configuration menu
    Copy the full SHA
    3e9f50b View commit details
    Browse the repository at this point in the history