Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update patch_click #133

Merged
merged 3 commits into from Mar 30, 2022
Merged

Update patch_click #133

merged 3 commits into from Mar 30, 2022

Conversation

jmsmkn
Copy link
Contributor

@jmsmkn jmsmkn commented Mar 29, 2022

Borrowed from patch_click in black 22.3.0

Fixes #132

@jmsmkn
Update patch_click
f703415 
Borrowed from `patch_click` in `black` 22.3.0

Fixes #132
@adamchainz
Copy link
Contributor

LGTM!

Here's the equivalent PR on Black: https://github.com/psf/black/pull/2966/files

@jmsmkn
Update Black
db62332
@jmsmkn
Update type annotations
23c5193 
type: ignore [misc] added to `main()` call due to changes in
click 8.1.0, see pallets/click#2227
@lb- lb- mentioned this pull request Mar 30, 2022
Merged
thibaudcolas
thibaudcolas approved these changes Mar 30, 2022
View reviewed changes
Copy link
Owner

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @jmsmkn! This looks excellent. Thank you Adam for checking it as well :) I’ll make a release shortly.

@thibaudcolas thibaudcolas added the bug Something isn't working label Mar 30, 2022
@thibaudcolas thibaudcolas merged commit 5bd2922 into thibaudcolas:main Mar 30, 2022
@thibaudcolas thibaudcolas added this to the v0.14.0 milestone Mar 30, 2022
@jmsmkn jmsmkn deleted the 132_fix_click branch March 30, 2022 08:28
@adamchainz
Copy link
Contributor

Thanks for the quick merge and release! Now I can remove the click pin from affected projects.

@jmsmkn
Copy link
Contributor Author

jmsmkn commented Mar 30, 2022

Thank you both for the quick review, release, and for the excellent software!

@lb-
Copy link

lb- commented Mar 30, 2022

Thanks all.

@thibaudcolas thibaudcolas removed this from the v0.14.0 milestone Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pip install curlylint does not work due to incompatability with click 8.1.0
4 participants
@jmsmkn @adamchainz @lb- @thibaudcolas