-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack side effect #25
Webpack side effect #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice @JipSterk! I had a look at other projects implementing this flag, and none bothered adding tests for it. From what I can see the tests you added just test that the flag works as intended, they don't test that the code actually is free of side-effects.
Could you remove all of the changes introduced here except for adding the flag in the package.json
? Then I'll merge the PR.
# [2.1.0](v2.0.1...v2.1.0) (2018-10-26) ### Features * **release:** mark package as side-effects-free for Webpack ([#25](#25)) ([38f1aa0](38f1aa0))
🎉 This pull request is included in v2.1.0, available on npm: draftjs-filters@2.1.0. Generated by 📦🚀 semantic-release |
Implements #24