Webpack side effect #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudcolas
requested changes
Oct 15, 2018
There was a problem hiding this comment.
Nice @JipSterk! I had a look at other projects implementing this flag, and none bothered adding tests for it. From what I can see the tests you added just test that the flag works as intended, they don't test that the code actually is free of side-effects.
Could you remove all of the changes introduced here except for adding the flag in the package.json? Then I'll merge the PR.
3 tasks
thibaudcolas
added
enhancement
thibaudcolas
approved these changes
Oct 26, 2018
thibaudcolas
added a commit
that referenced
this pull request
Oct 26, 2018
# [2.1.0](v2.0.1...v2.1.0) (2018-10-26) ### Features * **release:** mark package as side-effects-free for Webpack ([#25](#25)) ([38f1aa0](38f1aa0))
|
🎉 This pull request is included in v2.1.0, available on npm: draftjs-filters@2.1.0. Generated by 📦🚀 semantic-release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #24