Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow draft-js ^0.11.0 as a dependency #78

Merged
merged 1 commit into from
Oct 11, 2019
Merged

Allow draft-js ^0.11.0 as a dependency #78

merged 1 commit into from
Oct 11, 2019

Conversation

erikt9
Copy link
Contributor

@erikt9 erikt9 commented Oct 10, 2019

Resolves #77. Tests were able to pass without issue under latest 0.11


erik-imac:draftjs-filters filmfreeway$ npm info draft-js version
0.11.1
erik-imac:draftjs-filters filmfreeway$ npm test

> draftjs-filters@2.2.3 test /Users/filmfreeway/RubymineProjects/draftjs-filters
> react-scripts test --env=jsdom --coverage

 PASS  src/lib/filters/selection.test.js
 PASS  src/lib/filters/editor.test.js
 PASS  src/lib/filters/entities.test.js
 PASS  src/tests/paper.test.js
 PASS  src/tests/wordonline.test.js
 PASS  src/tests/docs.test.js
 PASS  src/demo/components/FilterableEditor.test.js
 PASS  src/tests/no-paste.test.js
 PASS  src/index.test.js
 PASS  src/tests/word.test.js
 PASS  src/tests/pages.test.js
 PASS  src/demo/components/SentryBoundary.test.js
 PASS  src/demo/index.test.js
  ● Console

    console.warn node_modules/draft-js/lib/DraftEditor.react.js:407
      Supplying an `onTab` prop to `DraftEditor` has been deprecated. If your handler needs access to the keyboard event, supply a custom `keyBindingFn` prop that falls back to the default one (eg. https://is.gd/RG31RJ).
    console.warn node_modules/draft-js/lib/DraftEditor.react.js:407
      Supplying an `onTab` prop to `DraftEditor` has been deprecated. If your handler needs access to the keyboard event, supply a custom `keyBindingFn` prop that falls back to the default one (eg. https://is.gd/RG31RJ).
    console.warn node_modules/draft-js/lib/DraftEditor.react.js:407
      Supplying an `onTab` prop to `DraftEditor` has been deprecated. If your handler needs access to the keyboard event, supply a custom `keyBindingFn` prop that falls back to the default one (eg. https://is.gd/RG31RJ).

 PASS  src/lib/filters/blocks.test.js
 PASS  src/tests/draftjs.test.js
 PASS  src/lib/filters/atomic.test.js
 PASS  src/demo/components/App.test.js
 PASS  src/lib/index.test.js
 PASS  src/lib/filters/text.test.js
 PASS  src/demo/components/Link.test.js
 PASS  src/demo/components/Image.test.js
 PASS  src/demo/components/Highlight.test.js
 PASS  src/lib/filters/styles.test.js

Test Suites: 23 passed, 23 total
Tests:       139 passed, 139 total
Snapshots:   47 passed, 47 total
Time:        4.22s, estimated 6s
Ran all test suites.
----------------------|----------|----------|----------|----------|-------------------|
File                  |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------------------|----------|----------|----------|----------|-------------------|
All files             |      100 |      100 |      100 |      100 |                   |
 src                  |      100 |      100 |      100 |      100 |                   |
  index.js            |      100 |      100 |      100 |      100 |                   |
  setupTests.js       |      100 |      100 |      100 |      100 |                   |
 src/demo             |      100 |      100 |      100 |      100 |                   |
  index.js            |      100 |      100 |      100 |      100 |                   |
 src/demo/components  |      100 |      100 |      100 |      100 |                   |
  App.js              |      100 |      100 |      100 |      100 |                   |
  FilterableEditor.js |      100 |      100 |      100 |      100 |                   |
  Highlight.js        |      100 |      100 |      100 |      100 |                   |
  Image.js            |      100 |      100 |      100 |      100 |                   |
  Link.js             |      100 |      100 |      100 |      100 |                   |
  SentryBoundary.js   |      100 |      100 |      100 |      100 |                   |
 src/demo/utils       |      100 |      100 |      100 |      100 |                   |
  polyfills.js        |      100 |      100 |      100 |      100 |                   |
 src/lib              |      100 |      100 |      100 |      100 |                   |
  constants.js        |      100 |      100 |      100 |      100 |                   |
  index.js            |      100 |      100 |      100 |      100 |                   |
 src/lib/filters      |      100 |      100 |      100 |      100 |                   |
  atomic.js           |      100 |      100 |      100 |      100 |                   |
  blocks.js           |      100 |      100 |      100 |      100 |                   |
  editor.js           |      100 |      100 |      100 |      100 |                   |
  entities.js         |      100 |      100 |      100 |      100 |                   |
  selection.js        |      100 |      100 |      100 |      100 |                   |
  styles.js           |      100 |      100 |      100 |      100 |                   |
  text.js             |      100 |      100 |      100 |      100 |                   |
 src/tests            |      100 |      100 |      100 |      100 |                   |
  fixtures.js         |      100 |      100 |      100 |      100 |                   |
  utils.js            |      100 |      100 |      100 |      100 |                   |
----------------------|----------|----------|----------|----------|-------------------|

@erikt9
Copy link
Contributor Author

erikt9 commented Oct 10, 2019

Updated commit message to pass commitlint

@thibaudcolas thibaudcolas merged commit 81ae721 into thibaudcolas:master Oct 11, 2019
thibaudcolas added a commit that referenced this pull request Oct 11, 2019
## [2.2.4](v2.2.3...v2.2.4) (2019-10-11)

### Bug Fixes

* **deps:** allow draft-js ^0.11.0 as a peer dependency ([#78](#78)) ([81ae721](81ae721))
@thibaudcolas
Copy link
Owner

🎉 This pull request is included in v2.2.4, available on npm: draftjs-filters@2.2.4.

Generated by 📦🚀 semantic-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow DraftJS ^0.11.0 as a peer dependency
2 participants