Vkontakte author info #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind. I was a bit confused by the UI. I got |
|
Merging this! |
|
👍 |
|
Hm, seems that <div class="fl_l people_cell">
<a class="ava" href="/lyanoi.kirill" onclick="return nav.go(this, event, {cl_id: 0})">
<img width="50" height="50" src="https://pp.vk.me/c623824/v623824699/55574/evmtX1Spupk.jpg"/>
</a>
<div class="name_field">
<a href="/lyanoi.kirill">
Кирилл<br />
<small></small>
</a>
</div>
</div>Anyway, I'll soon fix it and several other small issues. |
|
@drakmail Thanks for the heads up. I'll open up an issue for this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is NOT complete. I have only implemented
#authorand#author_thumbnail.I am posting this now because I need some help with
#author_url. I'm not totally sure what an author's URL is expected to be on Vkontakte. Maybe @drakmail knows?(Also, nice regex skills whoever wrote this initially. I'm a weenie and I just used
String::split)Also, heads up. One spec is expected to fail. It is unrelated to this PR. It is because of issue 125#125 is fixed and I rebase, so this should be green. Just waiting on some help with the
#author_urlpart.