Feature Vimeo v3 #87
Merged
Feature Vimeo v3 #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -122,22 +125,22 @@ | |||
|
|
|||
| describe '#date' do | |||
| subject { super().date } | |||
| it { is_expected.to eq Time.parse('2008-04-14 13:10:39', Time.now.utc) } | |||
| it { is_expected.to eq Time.parse('2008-04-14T17:10:39+00:00', Time.now.utc).utc } | |||
|
Master should be back to green now, could you rebase please? Thanks! |
|
@zdb I rebased your changes with master. I pushed it to branch It looks like some things are failing: 1) VideoInfo::Providers::VimeoPlaylist with playlist 1921098 #thumbnail_small should eq "https://i.vimeocdn.com/video/1921098_100x75.jpg"
Failure/Error: it { is_expected.to eq 'https://i.vimeocdn.com/video/1921098_100x75.jpg' }
expected: "https://i.vimeocdn.com/video/1921098_100x75.jpg"
got: "https://i.vimeocdn.com/video/299773432_100x75.jpg"
(compared using ==)
# ./spec/lib/video_info/providers/vimeo_playlist_spec.rb:125:in `block (4 levels) in <top (required)>'
2) VideoInfo::Providers::VimeoPlaylist with playlist 1921098 #thumbnail_medium should eq "https://i.vimeocdn.com/video/1921098_200x150.jpg"
Failure/Error: it { is_expected.to eq 'https://i.vimeocdn.com/video/1921098_200x150.jpg' }
expected: "https://i.vimeocdn.com/video/1921098_200x150.jpg"
got: "https://i.vimeocdn.com/video/299773432_200x150.jpg"
(compared using ==)
# ./spec/lib/video_info/providers/vimeo_playlist_spec.rb:130:in `block (4 levels) in <top (required)>'
3) VideoInfo::Providers::VimeoPlaylist with playlist 1921098 #thumbnail_large should eq "https://i.vimeocdn.com/video/1921098_640.jpg"
Failure/Error: it { is_expected.to eq 'https://i.vimeocdn.com/video/1921098_640.jpg' }
expected: "https://i.vimeocdn.com/video/1921098_640.jpg"
got: "https://i.vimeocdn.com/video/299773432_640.jpg"
(compared using ==)
# ./spec/lib/video_info/providers/vimeo_playlist_spec.rb:135:in `block (4 levels) in <top (required)>'There are also a couple Hound-CI warnings outside of the specs that don't seem to have been resolved. Can you have a look at these? Thanks! |
|
Also, it looks like this doesn't work without an API key, right? If so, should we make an issue for a Vimeo scraper, @thibaudgg? |
|
@vheuken a scraper sounds good! |
|
@vheuken Thanks for that. Yes, an API key is required for the v3 API. I'll look into the test that are failing. |
Closed
Vimeo API v2 has been deprecated. Version 3 now requires an access token for API calls. This also allows video_info to fetch a users private videos. Access tokens can be obtained here: https://developer.vimeo.com/apps
| end | ||
|
|
||
| describe '#thumbnail_medium' do | ||
| subject { super().thumbnail_medium } | ||
| it { is_expected.to eq 'http://i.vimeocdn.com/video/299773432_200x150.jpg' } | ||
| it { is_expected.to eq 'https://i.vimeocdn.com/video/299773432_200x150.jpg' } |
|
|
||
| def thumbnail(width = 200, height = nil) | ||
| base_uri = "https://i.vimeocdn.com/video/#{thumbnail_id}" | ||
| height ? base_uri + "_#{width}x#{height}.jpg" : base_uri + "_#{width}.jpg" |
|
I was going to comment on the HoundCI warnings, but those seem to all be from strings that are slightly too long, which isn't a big deal. Thanks! |
|
Thanks for the merge. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates Vimeo provider to version 3 of Vimeo's API.
Vimeo API v2 has been deprecated. Version 3 now requires an access token for API calls. This also allows video_info to fetch a users private videos.