Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(encode) calculate appropriate encoded_len #21

Merged
merged 6 commits into from
Nov 29, 2016
Merged

Conversation

thibaultcha
Copy link
Owner

No description provided.

@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling 0ae45f0 on feat/variable-len into c6953ae on master.

Use 'argon2_encodedlen()' to determine the appropriate length of the
encoded hash. 108 (old constant value) turned out to not always be
desired/big enough, causing failures to encode especially with long
salts.

See thibaultcha/lua-argon2-ffi#8
@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling 2919d31 on feat/variable-len into c6953ae on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling 2919d31 on feat/variable-len into c6953ae on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.007%) to 99.138% when pulling 2919d31 on feat/variable-len into c6953ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling 398777f on feat/variable-len into c6953ae on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling 398777f on feat/variable-len into c6953ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling 398777f on feat/variable-len into c6953ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling 398777f on feat/variable-len into c6953ae on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling 398777f on feat/variable-len into c6953ae on master.

@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage decreased (-0.8%) to 98.291% when pulling b790c27 on feat/variable-len into c6953ae on master.

@coveralls
Copy link

coveralls commented Nov 29, 2016

Coverage Status

Coverage increased (+0.01%) to 99.145% when pulling 09fbc7a on feat/variable-len into c6953ae on master.

@thibaultcha thibaultcha merged commit 9b0ea1d into master Nov 29, 2016
@thibaultcha thibaultcha deleted the feat/variable-len branch November 29, 2016 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants