Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sanity check to n.pca.max to default to max value if vector #323

Merged
merged 2 commits into from Apr 13, 2022
Merged

add sanity check to n.pca.max to default to max value if vector #323

merged 2 commits into from Apr 13, 2022

Conversation

pdimens
Copy link
Contributor

@pdimens pdimens commented Feb 9, 2022

This is an extra sanity check to make sure #322 cannot happen

@zkamvar
Copy link
Collaborator

zkamvar commented Feb 9, 2022

Thank you for the contribution! I will need to add a test in https://github.com/thibautjombart/adegenet/blob/master/tests/testthat/test_xval.R to make sure it does not regress.

Could you add your name to the DESCRIPTION file with a "ctb" role?

@pdimens
Copy link
Contributor Author

pdimens commented Feb 9, 2022

Added

@zkamvar zkamvar merged commit ca376af into thibautjombart:master Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants