Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing state containing regex with backslashes down to the webview #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix passing state containing regex with backslashes down to the webview #132

wants to merge 1 commit into from

Commits on Jan 31, 2024

  1. Fix passing state containing regex with backslashes down to the webview 

    We used to pass `state` to the webview by converting it to a JS expression string to be evaluated.

This led to special characters (e.g. backslashes) not being escaped properly in regular expressions (they need to be escaped twice for this to work) which, in turn, prevented the web app from parsing this JSON string back into an object.

The workaround is to pass the same stringified state but encoded it as base64 so we don't have to worry about escaping special characters
    @rodionovd
    rodionovd committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    edc48b8 View commit details
    Browse the repository at this point in the history