Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

symbol #28

Merged
merged 2 commits into from
May 17, 2017
Merged

symbol #28

merged 2 commits into from
May 17, 2017

Conversation

thierryc
Copy link
Owner

symbol replace too

symbol
47db743 
symbol replace too
@thierryc thierryc mentioned this pull request May 17, 2017
Open
@mscodemonkey mscodemonkey merged commit 6f93993 into thierryc:master May 17, 2017
@seandellis
Copy link
Collaborator

@thierryc Thanks for doing this!

It worked great on a simple document, but has issues on this test document. I've attached a GIF and the test document to reproduce.

Steps to Reproduce

Tested on Sketch v44

  • Open Test-Find And Replace.sketch
  • Use Find And Replace with the following options
    • Find: Occupation
    • Replace: TESTING
    • Scope: Whole Document
    • Case Insensitive
    • Case replacement: Standard
    • Where: Anywhere in Layer
    • Match Whole Words: No

Expected

Find all instances of Occupation in text and symbols and replace with TESTING.

Results

The areas marked with red arrows don't change, but the words marked with green arrows do.

bug-find and replace

Test-Find And Replace.zip

@thierryc
Copy link
Owner Author

Thanks

@thierryc
Copy link
Owner Author

thierryc commented May 17, 2017 •
edited

I Fix it !

#29

screen shot 2017-05-17 at 15 17 21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thierryc @seandellis @mscodemonkey