Fix calculation in Mpbs vs MB_s #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When measuring in bits (kbps and Mbps), use k == 1000, M == 1000000 When measuring in bytes (kB_s and MBps), use k == 1024, M == 1024**2 Also added a unittest for this calculation
|
Thanks @rustyhowell you are right, I got my bits mixed up here. The world should all just agree 1k is 1024 but I guess we'll have to settle. I'll merge your changes and push out a new version to PyPi later today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting conflicting Mbits/sec results from iperf3-python vs iperf3 on the command line. After investigation, I found the math error.
Commit msg:
When measuring in bits (kbps and Mbps), use k == 1000, M == 1000000
When measuring in bytes (kB_s and MB_s), use k == 1024, M == 1024**2
Also added a unittest for this calculation