Add support for Sublime Text 3 #3
Conversation
…e we don't need suppport for python < 2.4
|
Can you add |
|
Oh, lol, disregard my other comment in #1 :) |
| from collections import OrderedDict | ||
| except ImportError: | ||
| from ordereddict import OrderedDict | ||
| from collections import OrderedDict |
There was a problem hiding this comment.
this will probably break ST2 installs, why did you remove the try/except?
My st2 install gives me this version:
>>> import sys
>>> print (sys.version)
2.6.7 (r267:88850, Oct 11 2012, 20:15:00)
[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)]
http://docs.python.org/2/library/collections.html#collections.OrderedDict
If you look there, ordereddict was added in v2.7
There was a problem hiding this comment.
Oh, you're right, I misread. I thought it was added in 2.4 but now I see that it's collections that was added in 2.4, and OrderedDict was added in 2.7.
I removed it because ordereddict.OrderedDict depends on UserDict which doesn't exist in python 3 and leads to an import error. I'll add an if statement and send another pull request. Good call!
There was a problem hiding this comment.
No worries. I'll merge the PR as soon as this gets fixed. Thanks for your contribution!
|
This pull request is superseded by #4. |
These are the changes I had to make in order to get this plugin to work with ST3. They are pretty straight forward so I don't think I broke anything, but I've only tested the import sorter and I haven't tested backwards compatibility for ST2
I removed ordereddict.OrderedDict because it doesn't seem necessary to support for python < 2.4, and UserDict was removed in python 3.
I hope this is useful to people.