Fixed inconsistent styling and added ability to modify level/showLevel after init #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rowanG077 - do you think we can split out the implementation changes from the cosmetic changes, so this gets easier to review? |
|
//cc @thijse |
|
Yeah I can do that. I made two commits already, one for the styling and one for the added getters/setters. Do you prefer two separate pull requests? |
|
Regarding the style changes. I would also like to change the defined LogLevels to an enum class to get more safety on the interface and clearer usage. However this would be an API change and require a version bump. If you guys are OK with this I can implement that as well. |
rowanG077
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have the use case that I want to change the loglevel on the fly when running a program. This pull request adds getters and setters to be able to change the loglevel and showLog after init.
I also noticed that the styling was very inconsistent with different comment styles mixed, function parameters were spaces where placed differently and tabs/spaces where mixed. So I brought it together into a single style.