Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker run #344

Merged
merged 3 commits into from
Feb 10, 2024
Merged

Fix docker run #344

merged 3 commits into from
Feb 10, 2024

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Docker run example doesn't work because of the spaces in SERVER_NAME & SERVER_DESCRIPTION

Choices

  • Changed to quotes so spaces work
  • Changed other values which can have spaces quotes
  • Changed volume bind to match docker compose

Test instructions

  1. Run the docker run examples
  2. Verify the variables don't show quotes in the container

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef thijsvanloef merged commit 8fdc434 into thijsvanloef:main Feb 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsvanloef thijsvanloef thijsvanloef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Dashboy1998 @thijsvanloef