Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent reboot if there are players online #347

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Prevent reboot if there are players online #347

merged 1 commit into from
Feb 11, 2024

Conversation

raimannma
Copy link
Contributor

@raimannma raimannma commented Feb 10, 2024 •
edited

Context

  • The Auto-Reboot-Feature reboots while players are activly playing.

Choices

  • Used RCON to determine how many players are online

Test instructions

  1. Build Docker Image
  2. Run the examples
  3. Run the examples with AUTO_REBOOT_EVEN_IF_PLAYERS_ONLINE=true

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README. (I can't do the "kr" and "zh-CN" Version)
  • I've not introduced breaking changes.

@raimannma raimannma marked this pull request as ready for review February 10, 2024 13:19
@raimannma raimannma changed the title Reboot even if there are players online Prevent reboot if there are players online Feb 10, 2024
@raimannma raimannma mentioned this pull request Feb 10, 2024
Merged
3 tasks
@thijsvanloef thijsvanloef merged commit e1add5e into thijsvanloef:main Feb 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsvanloef thijsvanloef thijsvanloef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raimannma @thijsvanloef