Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for the server to shutdown before restoring a backup #378

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

Luatan
Copy link
Contributor

@Luatan Luatan commented Feb 12, 2024

Context

Choices

  • Getting the PID of the PalServer-Linux-Test binary to test if it is still running
  • Continue with the restore only after the server has shutdown

Test instructions

  1. Start a Server
  2. Create a backup
  3. Extract the backup and change the id in /palworld/Pal/Saved/Config/LinuxServer/GameUserSettings.ini
  4. Rename the directory in /palworld/Pal/Saved/SaveGames/0/ to the ID in GameUserSettings.ini
  5. Tar the 'Saved' directory again
  6. Run the restore command docker exec -it palworld-server restore
  7. Select the backup which was altered
  8. Verify that the server has restarted
  9. Verify that the ID in GameUserSettings.ini is the same which was used in the backup
  10. Verify that the directory in /palworld/Pal/Saved/SaveGames/0/ has the correct name

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

scripts/restore.sh Outdated Show resolved Hide resolved
scripts/restore.sh Show resolved Hide resolved
Co-authored-by: Carlos Martinez <Dashboy1998@gmail.com>
@thijsvanloef thijsvanloef merged commit 3aeebf6 into thijsvanloef:main Feb 14, 2024
8 checks passed
@Luatan Luatan deleted the restore-from-different-server branch February 15, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restoring backup from another server does not work using restore script
3 participants