Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added german language files #403

Merged
merged 5 commits into from
Feb 18, 2024
Merged

added german language files #403

merged 5 commits into from
Feb 18, 2024

Conversation

temmiland
Copy link
Contributor

@temmiland temmiland commented Feb 17, 2024

Context

  • This PR adds german language support for the docusaurus.

Choices

Test instructions

  1. Navigate to the docusaurus folder
  2. Run: npm start -- --locale de

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@temmiland
Copy link
Contributor Author

temmiland commented Feb 17, 2024

Hi 😄
I just wanted to make it clear that I've started translating, not that several people are making the effort at the same time and can translate together instead.

Please only merge when everything is translated.

@MSpreckels
Copy link
Contributor

you might want to mark it as draft if you dont want @thijsvanloef to merge it :)

@temmiland temmiland marked this pull request as draft February 17, 2024 20:25
@temmiland temmiland marked this pull request as ready for review February 17, 2024 22:26
@temmiland
Copy link
Contributor Author

Hey guys 👋🏼
I squashed my commits into one commit, so that everything is easier to maintain 😄

I also checked that everything looks good in docusaurus and checked the links pointing to headings hopefully work in production. I used the Dutch language files as a guide because it works there.

In the meantime there have been markdown lint checks. Unfortunately I can't see the current status.

If there is anything that needs to be fixed, please let me know. 😊

Copy link
Contributor

@MSpreckels MSpreckels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I've skimmed over the translation and found a few things. IMO, it's an accurate translation which sometimes feels abit stiff.

@temmiland
Copy link
Contributor Author

temmiland commented Feb 18, 2024

Hi thanks! I have added your suggestions. I also tried not to change too much of the meaning and form of the original texts. And in some places it was actually a bit stiff.

@thijsvanloef thijsvanloef merged commit ff08150 into thijsvanloef:main Feb 18, 2024
9 checks passed
@temmiland temmiland deleted the i18n-german branch February 18, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants