Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed image size #410

Merged
merged 5 commits into from
Feb 20, 2024
Merged

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Reduces image size
  • Also delete /tmp/dumps to remove this error when starting as nonroot and a user which does not have a UID of 1000 /tmp/dumps is not owned by us - delete and recreate

Choices

Previously we changed the permission of /home/steam/steamcmd/ which resulted in an image size increase of 300MB. Now making the directory we need and changing it's permission

Test instructions

  1. Test that is runs with the default compose
  2. Test as user 1000:1000
  3. Test as any other user

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@thijsvanloef
Copy link
Owner

Hi @Dashboy1998 Thanks for making this so quick, however I don't see a size difference:

REPOSITORY                            TAG       IMAGE ID       CREATED          SIZE
thijsvanloef/palworld-test            latest    aae0af4139c1   5 minutes ago    781MB
thijsvanloef/palworld-server-docker   dev       5a1bf2134d3a   18 minutes ago   781MB
thijsvanloef/palworld-server-docker   latest    001d8c947cbc   7 days ago       476MB

Dockerfile Outdated Show resolved Hide resolved
@thijsvanloef
Copy link
Owner

@Dashboy1998 Thanks for taking the time to work with me on this one, gonna test and merge tomorrow

@thijsvanloef thijsvanloef merged commit 63e2001 into thijsvanloef:main Feb 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants