Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player logging #424

Merged
merged 15 commits into from
Feb 22, 2024
Merged

Conversation

Dashboy1998
Copy link
Contributor

@Dashboy1998 Dashboy1998 commented Feb 21, 2024

Context

  • Currently the game does not announce when players join or leave nor is it logged

Choices

  • Adding in logging as a background task

Test instructions

  1. Start a server
  2. Verify it logs it you leaving and joining in docker
  3. With players in game test with others joining
  4. Test multiple players joining within the same polling period
  5. Delete player data, create a new players with any name that may break it (Spaces, commas, numbers, etc)

Output will look like

palworld-server  | Dashboy1998 has joined
palworld-server  | Broadcasted: Dashboy1998_has_joined
palworld-server  | Dashboy1998 has left
palworld-server  | Broadcasted: Dashboy1998_has_left

If #425 has been merged then the output will be

palworld-server  | Broadcasted: Dashboy1998_has_joined
palworld-server  | Broadcasted: Dashboy1998_has_left

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Dashboy1998 Dashboy1998 marked this pull request as draft February 21, 2024 21:30
@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 21, 2024 22:40
@Dashboy1998 Dashboy1998 marked this pull request as draft February 21, 2024 22:58
@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 21, 2024 23:44
@Dashboy1998 Dashboy1998 changed the title Added player logging Add player logging Feb 22, 2024
@thijsvanloef
Copy link
Owner

nice work!

@thijsvanloef thijsvanloef merged commit f63a93d into thijsvanloef:main Feb 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants