Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Logging Improvement #431

Merged
merged 3 commits into from
Feb 23, 2024

Conversation

Dashboy1998
Copy link
Contributor

Context

  • Modify player logging to make more readable

Choices

  • Switching to comm so we can see who have left or join instead of iterating to determine their change

Test instructions

  1. Start a server
  2. Verify it logs it you leaving and joining in docker
  3. With players in game test with others joining
  4. Test multiple players joining within the same polling period
  5. Delete player data, create a new players with any name that may break it (Spaces, commas, numbers, etc)

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@Dashboy1998 Dashboy1998 marked this pull request as ready for review February 22, 2024 15:41
@Dashboy1998 Dashboy1998 changed the title Switched back to comm Player Logging Improvement Feb 22, 2024
@thijsvanloef thijsvanloef merged commit 8f4ff78 into thijsvanloef:main Feb 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants