Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add default bShowPlayerList=True to PalWorldSettings.ini #461

Merged
merged 5 commits into from
Feb 27, 2024
Merged

add default bShowPlayerList=True to PalWorldSettings.ini #461

merged 5 commits into from
Feb 27, 2024

Conversation

MusclePr
Copy link
Contributor

@MusclePr MusclePr commented Feb 27, 2024 •
edited

Context

Choices

  • I think True is better than the default bShowPlayerList=False.
    It will be displayed even if you are not an admin.

Test instructions

  1. press ESC int the world.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I've added documentation about this change to the README.
  • I've not introduced breaking changes.

@MusclePr MusclePr mentioned this pull request Feb 27, 2024
Closed
@chowhi123
Copy link
Contributor

.env.example also requires this change. Thank you!

@MusclePr MusclePr force-pushed the update/v0.1.5.0-ShowPlayerListAlways branch from 4a125f8 to b0ace2e Compare February 27, 2024 08:42
@thijsvanloef
Copy link
Owner

Please also add documentation to the Docusaurus and readme

@thijsvanloef thijsvanloef added enhancement New feature or request needs documentation The PR is missing an entry in the docusaurus docs labels Feb 27, 2024
MusclePr and others added 3 commits February 27, 2024 17:58
@MusclePr
Update README.md
929b639 
Add description for environment variable SHOW_PLAYER_LIST.
@MusclePr
Update game-settings.md
5a05f3c 
Add description for environment variable SHOW_PLAYER_LIST.
@thijsvanloef
Merge branch 'main' into update/v0.1.5.0-ShowPlayerListAlways
68b3f40
@thijsvanloef thijsvanloef self-requested a review February 27, 2024 10:47
thijsvanloef
thijsvanloef approved these changes Feb 27, 2024
View reviewed changes
Copy link
Owner

@thijsvanloef thijsvanloef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works like a charm

@thijsvanloef thijsvanloef merged commit 9462ef7 into thijsvanloef:main Feb 27, 2024
10 checks passed
@MusclePr MusclePr deleted the update/v0.1.5.0-ShowPlayerListAlways branch May 7, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijsvanloef thijsvanloef thijsvanloef approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request needs documentation The PR is missing an entry in the docusaurus docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MusclePr @chowhi123 @thijsvanloef