Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifying Supercronic Related Code in start.sh #540

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

kimzuni
Copy link
Contributor

@kimzuni kimzuni commented Apr 24, 2024

Context

  1. Before registering Supercronic, check the size of the crontab file, not variables value.
  2. If you perform the task registered in Supercronic, the log as like:
    image

Choices

  1. If you modify it this way, you don't need to modify it even if related functions are added.
  2. Add the -passthrough-logs option to Supercronic so that the standard output of the file is displayed normally.
    image

Test instructions

  1. Set the BACKUP_ENABLED variable to false so that nothing is stored in the crontab file, and check whether the else part is executed.
  2. Set the BACKUP_ENABLED or AUTO_UPDATE_ENABLED variable to true to see if it goes to the if part, and check the log on which update was executed.

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

@thijsvanloef
Copy link
Owner

Love this change!

@thijsvanloef thijsvanloef merged commit 0b01c6d into thijsvanloef:main Apr 24, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants