Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed esm compatibility issues #2

Merged

Conversation

MarkusDeutschmann
Copy link
Contributor

  • added exports for esm & cjs and also types for:
    bowser-jr          -> "."
    bowser-jr/browser  -> "./browser"
    bowser-jr/engine   -> "./engine"
    bowser-jr/os       -> "./os"
    bowser-jr/platform -> "./platform"
    bowser-jr/compat   -> "./compat"
    
  • needed to switch the core module to 'type: "module"' to make ESM happy
  • also updated some dependencies (just minor ones)
  • fixed example how to import 'bowser-jr/compat'
  • increased the package version to 1.0.5

Copy link
Owner

@thillmann thillmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution and sorry for the delayed review!

@thillmann thillmann merged commit 680e6b9 into thillmann:main Jul 29, 2023
@MarkusDeutschmann MarkusDeutschmann deleted the fixed-esm-compatibility-issues branch August 2, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants