Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation to reflect Apama plugin changes #1489

Merged

Conversation

jdoc-sag
Copy link
Contributor

Proposed changes

The Apama team are taking over responsibility for the Apama plugin.
This pull request updates the Apama plugin documentation following changes to the plugin made by the Apama team.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@jdoc-sag jdoc-sag marked this pull request as ready for review November 16, 2022 16:20
- **Description**: apama-thin-edge-support (or something else if you choose)
- **Device Filter Type**: (leave empty)
- **Software Type**: apt
- **Version**: 10.15.1.0-1::apt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the version from the 10.15.1 branch - it should be 10.15.0.2 in the published version

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1. Name must be suffixed with `::project` as in `my-demo-project::project`
2. Version must be suffixed with `::apama` as in `1.0::apama` or just `::apama` if you don't need a version number.
3. The uploaded binary must be a `zip` file that contains the `project` directory. If a directory named `project` is not found at the root level in the zip, it's considered invalid.
1. The version must be suffixed with `::Apama` as in `1.0::Apama` or just `::Apama` if no version number is necessary.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The earlier version of the tedge-apama-plugin that thin-edge team developed was installing the plugin binary at /etc/tedge/sm-plugins as apama instead of Apama. So, if you'd like to replace the existing installations of the old plugin with the new one, you may also wanna name your plugin binary as apama and that same name needs to be used as the suffix here. Otherwise both will coexist on machines where the older plugin is already installed. But, if the intent was to keep both side-by-side, then this is fine.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure we are using lowercase and this is just a doc issue. The package will force-remove the tedge-apama-plugin when it installs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is lower case. This is a docs error caused by VS code, which I will fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Add the Apama thin-edge support package to the tenant software repository and deploy it to thin-edge
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might also wanna provide a link to where the user can download this apama thin-edge support package. I also hope that this support package will work even on a machine where apama is already installed, in which case, it will just install the Apama thin-edge plugin only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's not a fixed URL for the package - it depends on the version. The install instructions should be to install the apama-repo package (for which there is a fixed URL) and then install it as here using apt from the repo

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jdoc-sag and others added 3 commits November 25, 2022 15:27
Co-authored-by: Albin Suresh <albinsuresh@hotmail.com>
Co-authored-by: Albin Suresh <albinsuresh@hotmail.com>
Co-authored-by: Albin Suresh <albinsuresh@hotmail.com>
@didier-wenzek didier-wenzek merged commit cd29135 into thin-edge:main Nov 25, 2022
@didier-wenzek
Copy link
Contributor

Thank you for these updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants