Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docs/tutorials #1576

Merged
merged 16 commits into from
Nov 21, 2022
Merged

New docs/tutorials #1576

merged 16 commits into from
Nov 21, 2022

Conversation

hansb001
Copy link
Contributor

@hansb001 hansb001 commented Nov 10, 2022

Proposed changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@didier-wenzek
Copy link
Contributor

I will take the time for a review on Monday.

Beware that the last 2 commits are strange and need to be removed. I will help you to remove them.

hansb001 and others added 5 commits November 15, 2022 09:44
This document is a tutorial to install and configure thin-edge.io on a Raspberry Pi
screenshot from terminal "Connect to c8y"
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Hans Boef <hansboef@gmail.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Since the plan is to finalize the child-device.md doc in a follow-up PR, it's better to remove a draft from this one.
  • It would be better to avoid long lines that make diff a bit difficult to read. This also confuses the gui and some suggestions are blocked.

docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
docs/src/tutorials/getting-started.md Outdated Show resolved Hide resolved
hansb001 and others added 11 commits November 18, 2022 14:46
Signed-off-by: Hans Boef <hansboef@gmail.com>
Co-authored-by: Didier Wenzek <didier.wenzek@free.fr>
Co-authored-by: Didier Wenzek <didier.wenzek@free.fr>
Co-authored-by: Didier Wenzek <didier.wenzek@free.fr>
Co-authored-by: Didier Wenzek <didier.wenzek@free.fr>
Signed-off-by: Hans Boef <hansboef@gmail.com>
Signed-off-by: Hans Boef <hansboef@gmail.com>
Signed-off-by: Hans Boef <hansboef@gmail.com>
Signed-off-by: Hans Boef <hansboef@gmail.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@didier-wenzek didier-wenzek merged commit 72c0ab0 into thin-edge:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants