Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix string formatting warning #1588

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

reubenmiller
Copy link
Contributor

Signed-off-by: Reuben Miller reuben.miller@softwareag.com

Proposed changes

Fix the following compiler warning about a format string used in an error for tedge_agent:

    Compiling tedge_agent v0.8.1 (/workspaces/fork/crates/core/tedge_agent)
warning: named argument `timestamp` is not used by name
  --> crates/core/tedge_agent/src/error.rs:50:13
   |
50 |     #[error("Could not convert {timestamp:?} to unix timestamp. Error message: {}")]
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^--^
   |             |                                                                  |
   |             |                                                                  this formatting argument uses named argument `timestamp` by position

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Signed-off-by: Reuben Miller <reuben.miller@softwareag.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Approved

@reubenmiller reubenmiller merged commit ba34351 into thin-edge:main Nov 15, 2022
@reubenmiller reubenmiller deleted the fix-tedge-agent-warning branch November 15, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants