Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the error messages when certificates having issues for c8y #1589

Merged
merged 1 commit into from
Nov 15, 2022
Merged

Improve the error messages when certificates having issues for c8y #1589

merged 1 commit into from
Nov 15, 2022

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Nov 15, 2022

Proposed changes

When tedge connect c8y makes a direct connection to c8y, if there is an issue regarding certificate, the verbose output of errors is not helpful for end-users to understand what is the actual issue. This commit improves the printing error messages.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#1458

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

didier-wenzek
didier-wenzek approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with one suggestion.

crates/core/tedge/src/cli/connect/c8y_direct_connection.rs Outdated Show resolved Hide resolved
@rina23q
Improve the error messages when certificates having issues for c8y
1190a90 
When `tedge connect c8y` makes a direct connection to c8y, if there is
an issue regarding certificate, the verbose output of errors is not
helpful for end-users to understand what is the actual issue. This
commit improves the printing error messages.

Signed-off-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
@rina23q rina23q force-pushed the improvement/1458/cert-error-messages branch from d920916 to 1190a90 Compare November 15, 2022 18:21
@rina23q rina23q merged commit b505443 into thin-edge:main Nov 15, 2022
@rina23q rina23q deleted the improvement/1458/cert-error-messages branch November 15, 2022 18:37
@rina23q rina23q mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rina23q @didier-wenzek