Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cache from the job to build for arm architecture #1601

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Remove cache from the job to build for arm architecture #1601

merged 1 commit into from
Nov 22, 2022

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Nov 18, 2022

Proposed changes

The job for arm architecture with cache can fail sporadically. Stop using cache for those builds.

You can see the trial build: https://github.com/thin-edge/thin-edge.io/actions/runs/3498740838

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q
Remove cache from the job to build for arm architecture
2859635 
The job for arm architecture with cache can fail sporadically. Stop
using cache for those builds.

Signed-off-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
@rina23q rina23q self-assigned this Nov 18, 2022
@rina23q rina23q added ci/cd Repository management and pipeline topics bug Something isn't working labels Nov 18, 2022
PradeepKiruvale
PradeepKiruvale reviewed Nov 21, 2022
View reviewed changes
.github/workflows/build-workflow.yml
- name: Enable cache
# https://github.com/marketplace/actions/rust-cache
uses: Swatinem/rust-cache@v2

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a workaround for now. I feel its better to create an issue in the rust-cache.

reubenmiller
reubenmiller approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not ideal if it impacts the build times however favourable over unreliable builds.

@rina23q rina23q merged commit 9cb3e47 into thin-edge:main Nov 22, 2022
@rina23q rina23q deleted the ci/remove-cache branch November 22, 2022 11:49
@reubenmiller reubenmiller added this to the 0.9.0 milestone Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PradeepKiruvale PradeepKiruvale PradeepKiruvale left review comments

@reubenmiller reubenmiller reubenmiller approved these changes

Assignees

@rina23q rina23q

Labels
bug Something isn't working ci/cd Repository management and pipeline topics
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rina23q @reubenmiller @PradeepKiruvale