Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for latest version keyword #1615

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Add support for latest version keyword #1615

merged 2 commits into from
Nov 28, 2022

Conversation

cmosd
Copy link
Contributor

@cmosd cmosd commented Nov 28, 2022

Proposed changes

Users can set the version of an apt package equal to "latest" as a substitute for the default of blank space.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#1594

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • [] I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

didier-wenzek
didier-wenzek approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@cmosd cmosd force-pushed the improvement/1594/apt-latest branch from 3fa7a40 to 45d7b48 Compare November 28, 2022 15:12
Add support for latest version keyword
15c3533 
Users can set the version of an apt package equal to "latest" as
a substitute for the default of blank space.

Signed-off-by: alexandru solomes <solo@softwareag.com>
@cmosd cmosd force-pushed the improvement/1594/apt-latest branch from 45d7b48 to 15c3533 Compare November 28, 2022 15:44
Add "latest" version keyword in SM documentation
6ffb073 
Signed-off-by: alexandru solomes <solo@softwareag.com>
@reubenmiller reubenmiller mentioned this pull request Nov 28, 2022
Merged
@cmosd cmosd merged commit ae13582 into thin-edge:main Nov 28, 2022
@cmosd cmosd deleted the improvement/1594/apt-latest branch November 28, 2022 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

@reubenmiller reubenmiller Awaiting requested review from reubenmiller reubenmiller is a code owner

@albinsuresh albinsuresh Awaiting requested review from albinsuresh albinsuresh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmosd @didier-wenzek