Gracefully handle unknown config #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
An example of the warning messages: These messages are triggered any time the toml is read. Meaning it is not just triggered by the |
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
d273571
to
0c65888
Compare
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
0c65888
to
0adc184
Compare
cmosd
pushed a commit
to cmosd/thin-edge.io
that referenced
this pull request
Dec 2, 2022
Signed-off-by: alexandru solomes <solo@softwareag.com>
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
f54d302
to
e28b718
Compare
cmosd
pushed a commit
to cmosd/thin-edge.io
that referenced
this pull request
Dec 2, 2022
Signed-off-by: alexandru solomes <solo@softwareag.com>
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
e28b718
to
6766056
Compare
cmosd
pushed a commit
to cmosd/thin-edge.io
that referenced
this pull request
Dec 3, 2022
Signed-off-by: alexandru solomes <solo@softwareag.com>
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
7667160
to
a8f2af7
Compare
cmosd
pushed a commit
to cmosd/thin-edge.io
that referenced
this pull request
Dec 5, 2022
Signed-off-by: alexandru solomes <solo@softwareag.com>
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
a8f2af7
to
89c07e5
Compare
crates/common/tedge_config/src/tedge_config_cli/tedge_config_repository.rs
Show resolved
Hide resolved
| @@ -19,6 +19,7 @@ const BROKER_GROUP: &str = "mosquitto"; | |||
|
|
|||
| fn main() -> anyhow::Result<()> { | |||
| let opt = cli::Opt::parse(); | |||
| tedge_utils::logging::initialise_tracing_subscriber(false); | |||
There was a problem hiding this comment.
Is not it should be like below, this also needs to pass --debug flag when one uses the tedge cli.
Suggested change
| tedge_utils::logging::initialise_tracing_subscriber(false); | |
| tedge_utils::logging::initialise_tracing_subscriber(opt.debug); |
There was a problem hiding this comment.
This might be updated when merged with #1624.
There was a problem hiding this comment.
For this, we need to add --debug option for tedge command. This can be a separate PR.
added 4 commits
December 7, 2022 09:58
New macro crate that introduces the `serde_other` proc macro attribute for capturing unknown fields when deserialising to a struct. Signed-off-by: alexandru solomes <solo@softwareag.com>
Signed-off-by: alexandru solomes <solo@softwareag.com>
Added logging to `tedge` and warning is displayed when they toml field or keys are not known. Signed-off-by: alexandru solomes <solo@softwareag.com>
Signed-off-by: alexandru solomes <solo@softwareag.com>
cmosd
force-pushed
the
improvement/1623/gracefully-handle-unknown-config
branch
from
89c07e5
to
ab7d89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR:
other.tedgebinaryTypes of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments