-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add child device tutorial #1642
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following doc-wide changes are also required:
- Replace references to "child device agent" and "agent" with "child device connector" and "connector"
- It's a good markdown doc practice to keep multiple sentences in a paragraph across multiple lines instead of keeping them together. This makes the suggestions easier during reviews.
- Add images of the Cumulocity UI in relevant sections.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following things must be taken care of, at a doc level, before the next iteration:
- Use the admonish blocks as documented here for both Notes and Examples
- When accept commit suggestions, use the batch accept feature of github to avoid commits for each and every line as shown:
- Make sure that the markdown document renders properly, especially for numbered list items. There were many such numbering issues in the current version.
- Double check the links in the rendered version as some of my suggested headline changes will have an impact on these links as well.
b24d7c6
to
424161e
Compare
Signed-off-by: Hans Boef <hansboef@gmail.com>
424161e
to
82efe09
Compare
a9015a3
to
dd62e7a
Compare
@hansb001 Made the following major changes in my last commit:
|
dd62e7a
to
098b8a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Hans Boef hansboef@gmail.com
Proposed changes
Adding a tutorial for child device config management.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments