Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mdbook-toc dependency #1652

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

reubenmiller
Copy link
Contributor

@reubenmiller reubenmiller commented Dec 15, 2022

Signed-off-by: Reuben Miller reuben.miller@softwareag.com

Proposed changes

Removing an unused dependency on mdbook-toc.

This mdbook-toc issue is blocking the PR check workflow due to a dependency issue. Upon investigation it was found that the page "toc" functionality is not currently used. Once the issue is fixed the mdbook toc may be added in and the feature activated.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

An example of the error can be viewed here

Signed-off-by: Reuben Miller <reuben.miller@softwareag.com>
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Indeed mdbook-toc were not working as expected and we forgot to remove the dependency on it.

@reubenmiller reubenmiller merged commit ba8ef1f into thin-edge:main Dec 15, 2022
@reubenmiller reubenmiller deleted the fix-remove-mdbook-toc branch December 15, 2022 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants