Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort dependencies #1666

Merged
merged 2 commits into from
Dec 23, 2022
Merged

Sort dependencies #1666

merged 2 commits into from
Dec 23, 2022

Conversation

cmosd
Copy link
Contributor

@cmosd cmosd commented Dec 23, 2022 •
edited

Signed-off-by: alexandru solomes solo@softwareag.com

Proposed changes

Ran cargo sort -w . to sort all files in directory

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Sort dependencies
1623ef0 
Signed-off-by: alexandru solomes <solo@softwareag.com>
@cmosd cmosd added dependencies Pull requests that update a dependency file refactoring Developer value and removed refactoring Developer value labels Dec 23, 2022
@cmosd cmosd force-pushed the improvement/add-cargo-sort branch 2 times, most recently from 117110b to 203ccc7 Compare December 23, 2022 14:41
@cmosd cmosd marked this pull request as ready for review December 23, 2022 14:42
@cmosd cmosd requested a review from rina23q December 23, 2022 14:42
@rina23q
Add cargo sort pull-request check
a1ae278 
Signed-off-by: alexandru solomes <solo@softwareag.com>
Co-authored-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
rina23q
rina23q approved these changes Dec 23, 2022
View reviewed changes
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmosd cmosd merged commit 6286a22 into thin-edge:main Dec 23, 2022
@cmosd cmosd deleted the improvement/add-cargo-sort branch December 23, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rina23q rina23q rina23q approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmosd @rina23q