-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add vscode devcontainer definition #1690
Conversation
I added some docs to explain how to use the dev container (and install docker) |
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
8203124
to
0056199
Compare
|
||
More information about Dev Containers can be found from the [official documentation](https://code.visualstudio.com/docs/devcontainers/containers). | ||
|
||
## Setting up Docker (OSS - Variant) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just reference the other INSTALLING_DOCKER.md
doc here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right...I thought I updated this (I hope I didn't force push over the changes, as I swear I did link to the INSTALLAING_DOCKER.md
before...I will prepare another PR.
ms-vscode-remote.vscode-remote-extensionpack | ||
``` | ||
|
||
3. Currently the project does not have a `.devcontainer` folder so you will have to follow [these instructions](https://github.com/reubenmiller/vscode-dev-containers) first on how to add custom dev container templates for a project without having the files actually in the project. Don't worry this will not be required in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that it's merged, this line can be removed.
@@ -0,0 +1,110 @@ | |||
# Setting up Docker (OSS - Variant) | |||
|
|||
This guide is to assist with the installation of docker and some of the docker. It is not meant to replace other online articles but more of a cheat sheet to getting your setup up and running as fast as possible. If you encounter issues with the setup, please search online for a fix. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This guide is to assist with the installation of docker and some of the docker. It is not meant to replace other online articles but more of a cheat sheet to getting your setup up and running as fast as possible. If you encounter issues with the setup, please search online for a fix. | |
This guide is to assist with the installation of docker and some of the docker cli tools. It is not meant to replace other online articles but more of a cheat sheet to getting your setup up and running as fast as possible. If you encounter issues with the setup, please search online for a fix. |
Signed-off-by: Reuben Miller reuben.miller@softwareag.com
Proposed changes
Add a (VSCode) dev container definition which makes it easier for developers to develop by providing all of the project dependencies.
The dev container is an optional feature which enables VSCode users to start developing quickly as the dev containers includes all of the dependencies required to build/debug/run the project. It is currently only applicable for VSCode users, however the dev container definition contains a plain
Dockerfile
anddocker-compose.yml
that lists the dependencies making it easier for other IDE users to read and replicate in their applicable environments.To use a dev container locally on your machine, the following dependencies are required:
Alternatively, GitHub has a feature called Codespaces which also reads the dev container definition to launch a browser based IDE directly from GitHub.
The following is included in the dev container definition:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments