Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove remote access install #1706

Merged

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

The c8y-remote-access-plugin was added to the get-thin-edge_io.sh script (in #1694) even though it has not been officially released. This was causing the installation script to then fail due to 404 errors when trying to download a non-existent binary from the releases page.

It can be added back in once the next release is ready and the artifacts have been uploaded to the releases page.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added bug Something isn't working theme:packaging Theme: Packaging and release artefact topics labels Feb 1, 2023
@reubenmiller
Copy link
Contributor Author

@albinsuresh please rush the review of this because it causing error for our primary installation method.

The updating of the cargo lock file was necessary as the c8y-remote-access-plugin has to wrong version (which was probably the reason why it was failing the check on the original PR #1694.

Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not @albinsuresh but I can approve it :)

@albinsuresh albinsuresh merged commit 1ddfc0a into thin-edge:main Feb 2, 2023
@reubenmiller reubenmiller deleted the fix-remove-remote-access-install branch February 2, 2023 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working theme:packaging Theme: Packaging and release artefact topics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants