-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/publish artifacts - musl, zigbuild and cloudsmith #1712
Build/publish artifacts - musl, zigbuild and cloudsmith #1712
Conversation
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved the changes to cross-compile using zig.
I only got quick glance on the part related to Cloudsmith.
I will have a dedicated session detailing the Cloudsmith part (to double check the repo structure etc.). Though it does follow the same structure as JFrog (more or less). |
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Testing update / todo The following targets should be tested on real devices:
|
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
* use cargo-zigbuild for building * build musl variant by default * split build and publish jobs --------- Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Proposed changes
This PR is a bit cross cutting as there are three topics wrapped into one, but all of them relate to the building/publishing of the artifacts. I would like to push the topics in one go, rather than having 3 dependent PRs (but I am happy to change this if there are objections).
The following changes are included:
musl
variants (see next section for more details on why)build-workflow
to use one matrix job for all targets (instead of one job for x86_64, then a matrix job for the othersmain
branch and tags (as our version numbering is tag based).Why use musl variants instead of gnu?
glibc
(yes this was in there my default, and sometimes caused issues deploying on older Linux distributions.Downsides of the musl variants:
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments