Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish workflow: skip installation of build dependencies #1717

Merged
merged 3 commits into from
Feb 8, 2023
Merged

publish workflow: skip installation of build dependencies #1717

merged 3 commits into from
Feb 8, 2023

Conversation

reubenmiller
Copy link
Contributor

Signed-off-by: Reuben Miller reuben.d.miller@gmail.com

Proposed changes

Speed up the publish job from the build-workflow by removing the need to check the current version (as that does not matter for the publish part)

  • Remove the used variables from the publish step
  • Return early before the dependencies are installed when calling the build.sh script with the --version flag.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@reubenmiller
skip dep install for version check
ee9260b 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller
remove unused variables
121933f 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added improvement User value ci/cd Repository management and pipeline topics labels Feb 8, 2023
@reubenmiller
fix typo in publish notes
37930e1 
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller changed the title skip dep install for version check publish workflow: skip installation of build dependencies Feb 8, 2023
didier-wenzek
didier-wenzek approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller merged commit c04bd0d into thin-edge:main Feb 8, 2023
@reubenmiller reubenmiller deleted the skip-install-on-version-check branch February 8, 2023 16:25
Bravo555 pushed a commit to Bravo555/thin-edge.io that referenced this pull request Feb 14, 2023
@reubenmiller @Bravo555
publish workflow: skip installation of build dependencies (thin-edge#…
b122d83 
…1717)

* skip dep install for version check
* remove unused variables

---------

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@didier-wenzek didier-wenzek didier-wenzek approved these changes

Assignees
No one assigned
Labels
ci/cd Repository management and pipeline topics improvement User value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@reubenmiller @didier-wenzek