Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary build jobs from pull-request-checks workflow #1720

Merged

Conversation

reubenmiller
Copy link
Contributor

Signed-off-by: Reuben Miller reuben.d.miller@gmail.com

Proposed changes

Remove unnecessary build jobs from the pull-request-checks workflow. The PR checks already run cargo test which will build the binary anyway. Removing these tasks, also makes the pr check quicker.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
@reubenmiller reubenmiller added refactoring Developer value ci/cd Repository management and pipeline topics labels Feb 9, 2023
Copy link
Member

@rina23q rina23q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like to remove those jobs 👍

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@didier-wenzek
Copy link
Contributor

It's weird. Why is GitAction expecting status of checks that are no more launched?

@reubenmiller
Copy link
Contributor Author

It's weird. Why is GitAction expecting status of checks that are no more launched?

I’ll look at the GitHub config. I probably just have to remove it from the repo settings as well

@reubenmiller
Copy link
Contributor Author

It's weird. Why is GitAction expecting status of checks that are no more launched?

I’ll look at the GitHub config. I probably just have to remove it from the repo settings as well

I have updated the branch protection rule to remove those checks.

@reubenmiller reubenmiller merged commit 1113457 into thin-edge:main Feb 9, 2023
@reubenmiller reubenmiller deleted the pr-check-remove-armv7-build branch February 9, 2023 11:47
Bravo555 pushed a commit to Bravo555/thin-edge.io that referenced this pull request Feb 14, 2023
Signed-off-by: Reuben Miller <reuben.d.miller@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Repository management and pipeline topics refactoring Developer value
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants