-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document tedge_actors crate #1744
Merged
albinsuresh
merged 3 commits into
thin-edge:main
from
didier-wenzek:doc/document-actor-crate
Mar 8, 2023
Merged
Document tedge_actors crate #1744
albinsuresh
merged 3 commits into
thin-edge:main
from
didier-wenzek:doc/document-actor-crate
Mar 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
didier-wenzek
requested a deployment
to
Test Pull Request
February 22, 2023 17:17
— with
GitHub Actions
Waiting
didier-wenzek
temporarily deployed
to
Test Pull Request
February 24, 2023 17:14
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
didier-wenzek
force-pushed
the
doc/document-actor-crate
branch
from
February 27, 2023 15:05
8e31837
to
733096e
Compare
didier-wenzek
had a problem deploying
to
Test Pull Request
February 27, 2023 15:12
— with
GitHub Actions
Failure
didier-wenzek
force-pushed
the
doc/document-actor-crate
branch
from
February 27, 2023 20:45
733096e
to
334a591
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
February 27, 2023 20:52
— with
GitHub Actions
Inactive
albinsuresh
reviewed
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Observed a few recurring issues:
- There are still references to the old service concept which was renamed as server recently(I hope I have spotted and highlighted them all)
- The terms actor builder and message box builders are still used inconsistently. We probably need to stick to one (probably the former)
Yes, it seems I messed up things while rebasing. Fixed.
Agree. I will stick on the actor builder term. |
didier-wenzek
temporarily deployed
to
Test Pull Request
February 28, 2023 11:37
— with
GitHub Actions
Inactive
didier-wenzek
had a problem deploying
to
Test Pull Request
March 6, 2023 16:57
— with
GitHub Actions
Failure
didier-wenzek
force-pushed
the
doc/document-actor-crate
branch
from
March 6, 2023 17:03
b34c2a9
to
bb897f5
Compare
didier-wenzek
had a problem deploying
to
Test Pull Request
March 6, 2023 17:10
— with
GitHub Actions
Failure
Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
didier-wenzek
force-pushed
the
doc/document-actor-crate
branch
from
March 7, 2023 14:59
bb897f5
to
7c431d0
Compare
didier-wenzek
temporarily deployed
to
Test Pull Request
March 7, 2023 15:06
— with
GitHub Actions
Inactive
albinsuresh
reviewed
Mar 8, 2023
albinsuresh
had a problem deploying
to
Test Pull Request
March 8, 2023 09:26
— with
GitHub Actions
Failure
albinsuresh
temporarily deployed
to
Test Pull Request
March 8, 2023 09:44
— with
GitHub Actions
Inactive
albinsuresh
approved these changes
Mar 8, 2023
albinsuresh
added a commit
to albinsuresh/thin-edge.io
that referenced
this pull request
Mar 13, 2023
* Document tedge_actors crate Signed-off-by: Didier Wenzek <didier.wenzek@free.fr> Co-authored-by: Albin Suresh <albin.suresh@softwareag.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Documentation improvements [WIP]:
lib.rs
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments