Issue #1724 Derive actor configs from TEdgeConfig #1745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinsuresh
had a problem deploying
to
Test Pull Request
GitHub Actions
Failure
albinsuresh
commented
Feb 23, 2023
| @@ -77,3 +89,12 @@ async fn main() -> anyhow::Result<()> { | |||
| runtime.run_to_completion().await?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn mqtt_config(tedge_config: &TEdgeConfig) -> Result<MqttConfig, TEdgeConfigError> { | |||
There was a problem hiding this comment.
Instead of this function, I'd have preferred something like TryFrom<&TEdgeConfig> for MqttConifg but the compiler was not letting me do that with the error: error[E0117]: only traits defined in the current crate can be implemented for types defined outside of the crate.
The other option would have been either:
- Introduce a concrete wrapper impl for
MqttConifgand implement theTryFromfor that type - Implement the
TryFromfor themqtt_channel::Configitself. But, for that I need to make themqtt_channelcrate depend on thetedge_configcrate as well, which didn't seem like a good idea.
Since both were additional work for little benefit, I chose this path. But happy to fall back to either approach if you prefer one of those as well.
There was a problem hiding this comment.
I'm okay with that.
A 3rd alternative is to TryFrom<&TEdgeConfig> for MqttConfig in the tedge_config crate. This would add many dependencies to tedge_config but I see those less problematic.
Comment on lines
-7
to
-9
| #[derive(Clone, Debug, Default)] | ||
| pub struct HttpConfig {} | ||
|
|
There was a problem hiding this comment.
I agree to remove this for now, even if this might be useful later. Indeed, the plan was here to set options such as pool_idle_timeout
| @@ -77,3 +89,12 @@ async fn main() -> anyhow::Result<()> { | |||
| runtime.run_to_completion().await?; | |||
| Ok(()) | |||
| } | |||
|
|
|||
| fn mqtt_config(tedge_config: &TEdgeConfig) -> Result<MqttConfig, TEdgeConfigError> { | |||
There was a problem hiding this comment.
I'm okay with that.
A 3rd alternative is to TryFrom<&TEdgeConfig> for MqttConfig in the tedge_config crate. This would add many dependencies to tedge_config but I see those less problematic.
albinsuresh
force-pushed
the
issue/1724/actor-configs-from-tedge-config
branch
from
9cc8705
to
88c014a
Compare
albinsuresh
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Robot Results
Passed Tests
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Derive actor configs from TEdgeConfig
Types of changes
Paste Link to the issue
#1724
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments