-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clippy warning almost_swapped #1761
Fix clippy warning almost_swapped #1761
Conversation
Due to clap-rs/clap#4733 one has to revert back to clippy 1.64 Signed-off-by: Didier Wenzek <didier.wenzek@free.fr>
6d2c975
to
c46a174
Compare
Robot Results
Passed Tests
Failed Tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we can roll clippy back to 1.64 for the time being, but I reckon we can revert this once the underlying issue is solved? After AWS mapper, I'll take a look at this.
Yes, it will be good to have a deeper lock and to revert back to nightly. |
Actually the issue disappears when using stable clippy. The problem with the nightly toolchain, and clippy by extension, is because it's updated every day (or night), new issues may pop up every day forcing us to fix them, or as is the case here, clippy might just be working incorrectly and nothing is wrong with our code. This broken lint that got as blocked is relatively new, as I didn't have it before i upgraded from Whereas on stable:
For this reason, I think we should try staying on stable clippy. |
I agree with your arguments => let's use stable clippy. |
Proposed changes
allow almost_swapped
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments