-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All service statuses are set to down and remain down after restarting mosquitto #1788
Merged
reubenmiller
merged 5 commits into
thin-edge:main
from
PradeepKiruvale:mqtt-init-message
Mar 9, 2023
Merged
All service statuses are set to down and remain down after restarting mosquitto #1788
reubenmiller
merged 5 commits into
thin-edge:main
from
PradeepKiruvale:mqtt-init-message
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 3, 2023 10:20
— with
GitHub Actions
Failure
Robot Results
Passed Tests
Failed Tests
|
PradeepKiruvale
temporarily deployed
to
Test Pull Request
March 3, 2023 12:18
— with
GitHub Actions
Inactive
PradeepKiruvale
force-pushed
the
mqtt-init-message
branch
from
March 3, 2023 12:31
5c20dd2
to
63346c0
Compare
PradeepKiruvale
temporarily deployed
to
Test Pull Request
March 3, 2023 12:39
— with
GitHub Actions
Inactive
didier-wenzek
approved these changes
Mar 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 6, 2023 15:24
— with
GitHub Actions
Failure
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 7, 2023 02:28
— with
GitHub Actions
Failure
Signed-off-by: Pradeep Kumar K J <pradeepkumar.kj@softwareag.com>
Signed-off-by: Pradeep Kumar K J <pradeepkumar.kj@softwareag.com>
PradeepKiruvale
force-pushed
the
mqtt-init-message
branch
from
March 7, 2023 02:30
39e5987
to
83d6a9c
Compare
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 7, 2023 02:37
— with
GitHub Actions
Failure
PradeepKiruvale
temporarily deployed
to
Test Pull Request
March 7, 2023 07:08
— with
GitHub Actions
Inactive
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 7, 2023 09:23
— with
GitHub Actions
Failure
PradeepKiruvale
had a problem deploying
to
Test Pull Request
March 7, 2023 10:13
— with
GitHub Actions
Failure
PradeepKiruvale
temporarily deployed
to
Test Pull Request
March 7, 2023 12:48
— with
GitHub Actions
Inactive
@PradeepKiruvale Test is OK |
reubenmiller
added
theme:mqtt
Theme: mqtt and mosquitto related topics
theme:monitoring
Theme: Service monitoring and watchdogs
labels
Mar 9, 2023
albinsuresh
pushed a commit
to albinsuresh/thin-edge.io
that referenced
this pull request
Mar 13, 2023
… mosquitto (thin-edge#1788) * send init message on mqtt broker restart * add deterministic way of starting service --------- Signed-off-by: Pradeep Kumar K J <pradeepkumar.kj@softwareag.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
theme:monitoring
Theme: Service monitoring and watchdogs
theme:mqtt
Theme: mqtt and mosquitto related topics
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
When the MQTT broker restarts, the registered will messages that are registered to send out the health status
(down)
will be published. The connections will be restored after a while, still, the status remainsdown
.To address this issue an updated health status
up
message has to be sent. For this to work, need to register aninitial message
when themqtt
client is created. This message will be sent out when the connection is restored.So added an option to add the initial message
with_initial_message
function. Using this API, one can register theinitial message
.Types of changes
Paste Link to the issue
#1774
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments