-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the dependency of c8y-firmware-plugin and add test #1800
Merged
rina23q
merged 1 commit into
thin-edge:main
from
rina23q:fix/1793/add-package-dependency-c8y-firmware-plugin
Mar 9, 2023
Merged
Fix the dependency of c8y-firmware-plugin and add test #1800
rina23q
merged 1 commit into
thin-edge:main
from
rina23q:fix/1793/add-package-dependency-c8y-firmware-plugin
Mar 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
rina23q
temporarily deployed
to
Test Pull Request
March 8, 2023 17:38
— with
GitHub Actions
Inactive
Robot Results
Passed Tests
|
reubenmiller
approved these changes
Mar 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
albinsuresh
pushed a commit
to albinsuresh/thin-edge.io
that referenced
this pull request
Mar 13, 2023
Signed-off-by: Rina Fujino <18257209+rina23q@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix the issue reported in #1793.
Note: there are still suspicious dependency management regarding all plugins'
--init
directory creation.Types of changes
Paste Link to the issue
#1793
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments